------------------------------------------------------------------------
r913 | jlam | 2013-04-30 16:34:18 +0000 (Tue, 30 Apr 2013) | 1 line
Changed paths:
   A /tags/5.2.34 (from /trunk:912)

Tagging as 5.2.34 release.
------------------------------------------------------------------------
r912 | jlam | 2013-04-30 16:33:18 +0000 (Tue, 30 Apr 2013) | 9 lines
Changed paths:
   M /trunk/OvaleAura.lua

Don't account for stacking damage buffs for now.

Back out part of r814 that multiplied the damage increase by the stack
size.  There are very few stacking damage buffs, and those can be handled
explicitly for now until Ovale gains a way to describe a stacking versus a
non-stacking buff.

This fixes the result of the Damage() and LastSpellEstimatedDamage()
conditions.
------------------------------------------------------------------------
r911 | jlam | 2013-04-30 16:33:06 +0000 (Tue, 30 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleEquipement.lua

Recognize shaman caster tier 15 gear.
------------------------------------------------------------------------
r909 | jlam | 2013-04-23 17:21:33 +0000 (Tue, 23 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleData.lua

Add support for Ji-Kun Primal Nutrient buff. From @aggixx.
------------------------------------------------------------------------
r908 | jlam | 2013-04-23 17:21:26 +0000 (Tue, 23 Apr 2013) | 5 lines
Changed paths:
   M /trunk/OvaleState.lua

Generalize SpellAddBuff to allow more than "refresh" or a number.

Also fix ticket #240 "Monk keg smash LUA error" by sanity checking that
the aura specified in SpellAddBuff is followed by a number before assuming
it's a new aura applied by the spell.
------------------------------------------------------------------------
r907 | jlam | 2013-04-23 17:21:18 +0000 (Tue, 23 Apr 2013) | 4 lines
Changed paths:
   M /trunk/OvaleStance.lua

Update stance list when a new spell is learned.

Learning a new spell may change the stance bar, e.g., while leveling or
gaining a new talent or a new temporary ability.
------------------------------------------------------------------------
r905 | jlam | 2013-04-18 23:43:56 +0000 (Thu, 18 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Initialize a variable in a more clearly-documented way.
------------------------------------------------------------------------
r904 | jlam | 2013-04-18 23:43:49 +0000 (Thu, 18 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleCompile.lua

Minor optimization: release nodes in O(n) time, not O(n^2) time.
------------------------------------------------------------------------
r903 | jlam | 2013-04-18 23:43:41 +0000 (Thu, 18 Apr 2013) | 4 lines
Changed paths:
   M /trunk/OvaleCompile.lua
   M /trunk/OvaleOptions.lua

Sanity check that all functions called within the script are defined.

Create a new debugging toggle that reports undefined functions to the chat
window when a script is compiled.
------------------------------------------------------------------------
r902 | jlam | 2013-04-18 23:43:33 +0000 (Thu, 18 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleAura.lua

Fix ticket #237: Guard against nil aura table.
------------------------------------------------------------------------
r900 | jlam | 2013-04-10 07:20:55 +0000 (Wed, 10 Apr 2013) | 1 line
Changed paths:
   M /trunk/defaut/Pretre.lua

Shadow priest DoTs are affected by spell haste.
------------------------------------------------------------------------
r899 | jlam | 2013-04-10 07:20:46 +0000 (Wed, 10 Apr 2013) | 4 lines
Changed paths:
   M /trunk/defaut/Pretre.lua

Fix ticket #236 - Fixes for Ovale priest default script

Change the spell IDs of Halo and Divine Star to the shadow spec versions.
Thanks to @napgravy for the fix.
------------------------------------------------------------------------
r898 | jlam | 2013-04-10 07:20:39 +0000 (Wed, 10 Apr 2013) | 8 lines
Changed paths:
   M /trunk/defaut/Paladin.lua

Fix ticket #235 - Ret Paladin spell IDs

Execution Sentence has a different spell ID for the ability (114157) and
the debuff (114156).

Guardian of Ancient Kings has spell ID 86698 for retribution paladins.

Thanks to @stonecow for the correct spell IDs.
------------------------------------------------------------------------
r897 | jlam | 2013-04-10 07:20:33 +0000 (Wed, 10 Apr 2013) | 7 lines
Changed paths:
   M /trunk/OvaleAura.lua

Dynamically update tick length of auras applied by the player.

The tick times of a periodic aura applied by the player are taken from
watching for SPELL_PERIODIC CLEU events.  Those tick times are used to
update the estimate for the aura's tick length based on empirical
evidence, and is hopefully more accurate.  It also avoids needing to store
the haste percentage at which a periodic aura was applied.
------------------------------------------------------------------------
r896 | jlam | 2013-04-10 07:20:26 +0000 (Wed, 10 Apr 2013) | 34 lines
Changed paths:
   M /trunk/OvaleAura.lua

Change the way that auras are scanned and kept in the aura database.

Keep a separate aura age for each GUID so we can tell when an aura
previously present is missing in a new aura scan of that GUID without
affecting the determination of other unit's aura ages.  The age is simply
the number of times the unit's auras were scanned.

Be more strict about deciding when an aura found on a unit matches one
that was recently scanned on the same unit.  An aura is the same if the
following details match:

	caster, duration, expiration time, stack count

Being more strict helps to "age" the auras properly, instead of tossing
them out and getting new scans each time UpdateAuras/ScanUnitAuras is run.

These changes will allow us to store more metadata in the aura properties
about the player's state (e.g., tick length, crit chance, etc.) at the
time the aura was gained.

Also, store the caster's GUID in the aura properties instead of the
caster's unit ID.  The former is invariant and better suited to aura
scans triggered by CLEU events.

Rename two methods to be more descriptive about what they do:

	UpdateAuras -> ScanUnitAuras
	AddAura -> UnitGainedAura

Re-use code to remove expired auras and be more DRY.

Be smarter about when to trigger an Ovale refresh event by checking
whether auras have actually changed on a unit since they were last
scanned.
------------------------------------------------------------------------
r895 | jlam | 2013-04-10 07:20:19 +0000 (Wed, 10 Apr 2013) | 6 lines
Changed paths:
   M /trunk/OvaleGUID.lua

Sanity-check "mouseover"-related units in OvaleGUID method results.

Mouseover and mouseover-derived targets cached by OvaleGUID are not
necessarily valid because the cursor may have moved off the previous
mouseover target (there is no event fired for moving off).  Verify that
the mouseover unit is still there before returning these unit IDs.
------------------------------------------------------------------------
r893 | jlam | 2013-04-05 06:21:02 +0000 (Fri, 05 Apr 2013) | 4 lines
Changed paths:
   M /trunk/OvaleState.lua

Handle new SpellInfo parameter "cd_haste".

A spell whose cooldown is affected by haste effects can be tagged with
"cd_haste=melee" or "cd_haste=spell".
------------------------------------------------------------------------
r892 | jlam | 2013-04-05 06:20:55 +0000 (Fri, 05 Apr 2013) | 5 lines
Changed paths:
   M /trunk/OvaleData.lua

Allow for melee haste to affect the GCD between melee specials.

This is primarily for paladins, for whom melee haste does this through
Sanctity of Battle.  Those spells for which Sanctity of Battle apply
should be tagged with "haste=melee" in a SpellInfo line.
------------------------------------------------------------------------
r891 | jlam | 2013-04-05 06:20:49 +0000 (Fri, 05 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Add StaggerRemains() to get the remaining Stagger damage on a target.
------------------------------------------------------------------------
r890 | jlam | 2013-04-05 06:20:42 +0000 (Fri, 05 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleState.lua

Add debugging message for cooldowns of spell launched in the simulator.
------------------------------------------------------------------------
r889 | jlam | 2013-04-05 06:20:35 +0000 (Fri, 05 Apr 2013) | 1 line
Changed paths:
   M /trunk/Ovale.lua

Leave "Ovale" in the global namespace to ease debugging.
------------------------------------------------------------------------
r888 | jlam | 2013-04-05 06:20:28 +0000 (Fri, 05 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleBestAction.lua

Include node Id in the trace messages for easier debugging.
------------------------------------------------------------------------
r887 | jlam | 2013-04-05 06:20:21 +0000 (Fri, 05 Apr 2013) | 3 lines
Changed paths:
   M /trunk/OvaleCompile.lua

Remove unnecessary setting of Ovale.refreshNeeded["player"].

It is already toggled in the Compile method.
------------------------------------------------------------------------
r886 | jlam | 2013-04-05 06:20:14 +0000 (Fri, 05 Apr 2013) | 1 line
Changed paths:
   M /trunk/OvaleAura.lua
   M /trunk/OvaleSkada.lua

Don't leak names into the global namespace.
------------------------------------------------------------------------
r885 | jlam | 2013-04-05 06:20:07 +0000 (Fri, 05 Apr 2013) | 5 lines
Changed paths:
   M /trunk/OvaleFuture.lua

Fix bug in OvaleFuture broke accounting for spells in flight.

Catch up with removed method in debugging function.

Be more DRY by using a custom print function for traced spells.
------------------------------------------------------------------------
r883 | jlam | 2013-04-01 01:39:39 +0000 (Mon, 01 Apr 2013) | 5 lines
Changed paths:
   M /trunk/OvaleComboPoints.lua

Update combo points when the target changes or when the player zones in.

This fixes a bug where having 3 CPs up on one target then switching targets
causes Ovale to assume there are still 3 CPs up on the new target.
Reported by @Erizura in an Ovale rogue forum thread.
------------------------------------------------------------------------
r881 | jlam | 2013-03-31 20:31:39 +0000 (Sun, 31 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Catch up to a renamed function.
------------------------------------------------------------------------
r879 | jlam | 2013-03-31 18:55:01 +0000 (Sun, 31 Mar 2013) | 4 lines
Changed paths:
   M /trunk/OvaleFuture.lua
   M /trunk/OvaleState.lua

Fix for ticket 215 - Memory leak?

Invert design by replacing a stateful iterator with a callback.  This
avoids the (temporary) memory used by Lua to create and store closures.
------------------------------------------------------------------------
r878 | jlam | 2013-03-31 18:54:54 +0000 (Sun, 31 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Add new condition SpellKnown() to test for a spell in the spellbook.
------------------------------------------------------------------------
r876 | jlam | 2013-03-31 10:23:04 +0000 (Sun, 31 Mar 2013) | 10 lines
Changed paths:
   M /trunk/OvalePaperDoll.lua

Track critical strike chance and split bonus damage from bonus healing.

This isn't perfect.  This only updates the player's critical strike chance
if it's due to a change in critical strike rating.  If there is a buff
applied that provides a flat increase to a player's critical strike
chance, then it won't trigger the update.

We also use two different events for updating bonus damage and bonus
healing instead of just one, which may not necessarily have fired when
bonus healing changed.
------------------------------------------------------------------------
r875 | jlam | 2013-03-31 10:22:57 +0000 (Sun, 31 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleFuture.lua

Use a lookup table to be more efficient in a CLEU event handler.
------------------------------------------------------------------------
r874 | jlam | 2013-03-31 10:22:50 +0000 (Sun, 31 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Add new condition IsPVP() to check for PvP-flagged units.
------------------------------------------------------------------------
r873 | jlam | 2013-03-31 10:22:40 +0000 (Sun, 31 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleFuture.lua

Remove accidentally duplicated line.
------------------------------------------------------------------------
r871 | jlam | 2013-03-30 02:43:08 +0000 (Sat, 30 Mar 2013) | 6 lines
Changed paths:
   M /trunk/defaut/Chevalier.lua

Fix ticket #225 - Chat window error when click target with DK.

Change Death Knight script syntax to work around a parser bug with braces.
The parser doesn't correctly parse "a + b * {c / d}".
It parses it as "{a + b} * {c / d}".
The modified script does "a + {b * c / d}" to force the proper parse.
------------------------------------------------------------------------
r870 | jlam | 2013-03-30 02:43:00 +0000 (Sat, 30 Mar 2013) | 3 lines
Changed paths:
   M /trunk/OvaleCompile.lua

Back out previous as it's not a complete fix.

Leave it alone so that existing working scripts don't break.
------------------------------------------------------------------------
r869 | jlam | 2013-03-30 01:52:00 +0000 (Sat, 30 Mar 2013) | 14 lines
Changed paths:
   M /trunk/OvaleCompile.lua

Fix operator precedence error that was causing DK script issues.

Ovale was incorrectly parsing:

    a + b * {c / d}
as:
    {a + b} * {c + d}

This change makes it correctly parse as:

    a + {b * {c / d}}

This error was been in Ovale since MoP was released but it takes a rather
complex script to trigger it.
------------------------------------------------------------------------
r868 | jlam | 2013-03-30 01:51:53 +0000 (Sat, 30 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleCompile.lua

Fix "compare" node, which affected "Condition(more 5)" constructs.
------------------------------------------------------------------------
r867 | jlam | 2013-03-30 01:51:46 +0000 (Sat, 30 Mar 2013) | 5 lines
Changed paths:
   M /trunk/defaut/Demoniste.lua
   M /trunk/defaut/Pretre.lua
   M /trunk/defaut/Voleur.lua

Be explicit about tick length for auras that we request tick information.

The default scripts for warlocks, priests and rogues use TickRemains,
TickTime and Ticks conditions for several spells, and those spells now
need an explicit tick=N parameter in their respective SpellInfo lines.
------------------------------------------------------------------------
r866 | jlam | 2013-03-30 01:51:39 +0000 (Sat, 30 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleCondition.lua

Rename avecHate() to TimeWithHaste() and improve the documentation.
------------------------------------------------------------------------
r865 | jlam | 2013-03-30 01:51:31 +0000 (Sat, 30 Mar 2013) | 14 lines
Changed paths:
   M /trunk/OvaleCondition.lua

Cleanup of OvaleCondition.

* Rename getOtherAura to GetMyAuraOnAnyTarget and make it clear that it's
  a wrapper for OvaleState:GetMyAuraOnAnyTarget, much like how GetAura is
  a wrapper for OvaleState:GetAura.

* Merge fixes to Buff/Debuff conditions into "Other" conditions.

* Make function names start with a capital letter (cosmetic).

* Sort the private methods by category.

* Use OvaleDate:GetSpellName() instead of Blizzard API function
  GetSpellInfo where possible for efficiency.
------------------------------------------------------------------------
r864 | jlam | 2013-03-30 01:51:24 +0000 (Sat, 30 Mar 2013) | 1 line
Changed paths:
   M /trunk/compiler.pl

Make the check script pass the current code.
------------------------------------------------------------------------
r863 | jlam | 2013-03-30 01:51:16 +0000 (Sat, 30 Mar 2013) | 6 lines
Changed paths:
   M /trunk/OvaleSkada.lua

Make OvalaSkada into a direct module of Skada instead of proxying for one.

The previous wrapper object did nothing except use our own OnEnable() and
OnDisable() routines, which was unnecessary.  Simply add the required
registration lines to the Skada modules's OnEnable() and OnDisable()
routines directly.
------------------------------------------------------------------------
r862 | jlam | 2013-03-30 01:51:08 +0000 (Sat, 30 Mar 2013) | 1 line
Changed paths:
   M /trunk/OvaleGUID.lua

Remove unnecessary comment since OvaleGUID has a debugging toggle.
------------------------------------------------------------------------
